Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: improve feature presence automation #7789

Closed
wants to merge 1 commit into from

Conversation

ikerexxe
Copy link
Contributor

@ikerexxe ikerexxe commented Jan 8, 2025

files-provider stopped being shipped in Fedora 40 in sssd-2.9. Thus, the detection matrix need to be updated to take this into account.

In addition, the assertion messages weren't clear enough, so I've improved them to understand them at a first glance.

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank You for the improved messages.

`files-provider` stopped being shipped in Fedora 40 in sssd-2.9. Thus,
the detection matrix need to be updated to take this into account.

In addition, the assertion messages weren't clear enough, so I've
improved them to understand them at a first glance.

Signed-off-by: Iker Pedrosa <[email protected]>
@ikerexxe ikerexxe force-pushed the test-files-provider branch from 5217ccd to 14a2016 Compare January 10, 2025 11:05
@alexey-tikhonov
Copy link
Member

Pushed PR: #7789

  • master
    • 067dbf6 - tests: improve feature presence automation
  • sssd-2-10
    • c44bcb7 - tests: improve feature presence automation
  • sssd-2-8
    • 23c7d05 - tests: improve feature presence automation
  • sssd-2-9
    • eafffce - tests: improve feature presence automation
  • sssd-2-9-4
    • 03aaa68 - tests: improve feature presence automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants