Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Have coverity workflow run against PR code #7828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: Have coverity workflow run against PR code #7828

wants to merge 1 commit into from
+3 −0

Conversation

justin-stephenson
Copy link
Contributor

No description provided.

@alexey-tikhonov
Copy link
Member

@justin-stephenson, please set backport-to labels.

@justin-stephenson
Copy link
Contributor Author

@justin-stephenson, please set backport-to labels.

Done.

@andreboscatto andreboscatto requested review from ikerexxe and removed request for pbrezina February 11, 2025 13:34
@ikerexxe
Copy link
Contributor

So that we all understand the purpose of this PR. What you want is checks out the head branch of the pull request, instead of the base branch where the changes are intended to land. Am I right?

@justin-stephenson
Copy link
Contributor Author

So that we all understand the purpose of this PR. What you want is checks out the head branch of the pull request, instead of the base branch where the changes are intended to land. Am I right?

Yes that's correct, it is a side effect of using pull_request_target workflow

@ikerexxe
Copy link
Contributor

Can you update the commit message to make this obvious? It'd make everything easier to understand.

@justin-stephenson
ci: Have coverity workflow run against PR code
3ab7f85 
Checkout the head of the pull request code instead of the
target branch, this is needed when using `pull_request_target`
workflow.
@justin-stephenson
Copy link
Contributor Author

Can you update the commit message to make this obvious? It'd make everything easier to understand.

Sure no problem, done.

thalman
thalman approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

ikerexxe
ikerexxe approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalman thalman thalman approved these changes

@ikerexxe ikerexxe ikerexxe approved these changes

Assignees

@thalman thalman

@ikerexxe ikerexxe

Labels
Accepted branch: sssd-2-9 branch: sssd-2-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justin-stephenson @alexey-tikhonov @ikerexxe @thalman