Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Mobile | Settings improvements on tablets #1060

Merged
merged 5 commits into from
Sep 26, 2024
Merged

♻️ Mobile | Settings improvements on tablets #1060

merged 5 commits into from
Sep 26, 2024

Conversation

zacharykeeping
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Closes #1057

  1. What was changed?
  1. Adds a heading to the settings page (which also allows adding headings to other pages if we choose too)
  2. Adds a second column on the settings page on tablets to show the logo in the dead space
  3. Changes "Replay Intro" to "Getting Started 🎉"
  4. Fixes the size of popups on tablets (on the onboarding but also in other places where we're using popups as well)
  5. Also fixes the display of the user's QR code on tablets (doesn't stretch to the edge and get cut off now)

Simulator Screenshot - iPad (10th generation) - 2024-09-26 at 12 00 42

Figure: Settings page on tablet with heading, logo in the dead space, and updating onboarding naming

Simulator Screenshot - iPad (10th generation) - 2024-09-26 at 12 00 52

Figure: Popups like the onboarding now show correctly on tablets

  1. Did you do pair or mob programming?

No

matt-goldman-ssw
matt-goldman-ssw approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@matt-goldman-ssw matt-goldman-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharykeeping
Merge branch 'main' into settings-approvements
a297163 
# Conflicts:
#	src/MobileUI/Features/Settings/SettingsPage.xaml
#	src/MobileUI/Features/Settings/SettingsViewModel.cs
@zacharykeeping zacharykeeping merged commit e0a061e into main Sep 26, 2024
6 checks passed
@zacharykeeping zacharykeeping deleted the settings-approvements branch September 26, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-goldman-ssw matt-goldman-ssw matt-goldman-ssw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Mobile | Settings page improvements
2 participants
@zacharykeeping @matt-goldman-ssw