Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ Removed secret content Azure functions and containers #87

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

babakamyljanovssw
Copy link
Member

Issue: SSWConsulting/SSW.Rules#1622

This pull request includes removal SecretContent and User entities related to secret content feature, along with their related functions and cosmos db configurations.
The secret content wasn't being used and maintained causing huge amount of failure logs on Application Insights

Removal of Entities and Functions:

  • Removed the SecretContent entity class.
  • Removed the User entity class.

Changes in Functions:

  • Removed the creation and check of SecretContent entity in the health check function.
  • Deleted the GetSecretContentFunction class.
  • Deleted the AddUserOrganisationFunction class.
  • Deleted the GetOrganisationsFunction class.
  • Deleted the GetUserFunction class.

Database Configuration Updates:

  • Removed SecretContent and User repositories from the RulesDbContext class.
  • Removed container configurations for SecretContent and User entities.

Documentation Updates:

  • Removed API endpoints related to SecretContent and User functions.

@babakamyljanovssw
Copy link
Member Author

Hey @bradystroud @JackDevAU

Merging this PR, I've exported SecretContent and User containers as json object to my local just in case.
This merge will update the DB scheme, but it will not delete containers from Azure Cosmos DB, containers needs to be deleted manually.

@babakamyljanovssw babakamyljanovssw deleted the 1622-clean-up-funcs branch November 12, 2024 06:17
@babakamyljanovssw babakamyljanovssw restored the 1622-clean-up-funcs branch November 12, 2024 06:18
@babakamyljanovssw babakamyljanovssw merged commit 83f0a8e into main Nov 12, 2024
6 checks passed
@babakamyljanovssw babakamyljanovssw deleted the 1622-clean-up-funcs branch November 12, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants