Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute feature test for at_quick_exit #6583

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Execute feature test for at_quick_exit #6583

merged 5 commits into from
Dec 2, 2024

Conversation

SAtacker
Copy link
Contributor

  • I have fixed a potential bug

@SAtacker
[macOS] Comparison between exactly same types
76d847a 
Signed-off-by: Shreyas Atre <[email protected]>
@SAtacker
[macOS] Apple does not seem to have any typedef for unsigned long int
75973a8 
Signed-off-by: Shreyas Atre <[email protected]>
@SAtacker
Execute at_quick_exit feature test
5c36a4e 
- macOSs command line tools 16+ apparently has issues with at_quick_exit not found
- For those, this feature macro should be disabled as it cannot execute at runtime but compiles

Signed-off-by: Shreyas Atre <[email protected]>
@SAtacker
Revert "[macOS] Apple does not seem to have any typedef for unsigned …
1682407 
…long int"

This reverts commit 75973a8.

Signed-off-by: Shreyas Atre <[email protected]>
@SAtacker
Revert "[macOS] Comparison between exactly same types"
6ff0c9d 
This reverts commit 76d847a.

Signed-off-by: Shreyas Atre <[email protected]>
@SAtacker SAtacker requested a review from hkaiser as a code owner November 25, 2024 17:18
@hkaiser hkaiser added this to the 1.11.0 milestone Nov 25, 2024
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each------

Info

PropertyBeforeAfter
HPX Commitd27ac2e91cc0fb
HPX Datetime2024-03-18T14:00:30+00:002024-11-25T17:18:53+00:00
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2024-03-18T09:18:04.949759-05:002024-11-25T12:31:04.124182-06:00

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
HPX Commitd27ac2e91cc0fb
HPX Datetime2024-03-18T14:00:30+00:002024-11-25T17:18:53+00:00
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2024-03-18T09:19:53.062988-05:002024-11-25T12:32:54.254835-06:00

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add------
Stream Benchmark - Scale-----
Stream Benchmark - Triad------
Stream Benchmark - Copy------

Info

PropertyBeforeAfter
HPX Commitd27ac2e91cc0fb
HPX Datetime2024-03-18T14:00:30+00:002024-11-25T17:18:53+00:00
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2024-03-18T09:20:13.002391-05:002024-11-25T12:33:14.755976-06:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser
Copy link
Member

hkaiser commented Dec 1, 2024

@SAtacker what's the status of this? Can we go ahead and merge it?

@SAtacker
Copy link
Contributor Author

SAtacker commented Dec 1, 2024

@SAtacker what's the status of this? Can we go ahead and merge it?

Yes! Works for me

@hkaiser hkaiser merged commit e5746e6 into STEllAR-GROUP:master Dec 2, 2024
53 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser Awaiting requested review from hkaiser hkaiser is a code owner

Assignees
No one assigned
Labels
platform: Mac OSX type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SAtacker @StellarBot @hkaiser