Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test case added for kubectl container #710

Merged
merged 1 commit into from
Feb 7, 2025
Merged

test case added for kubectl container #710

merged 1 commit into from
Feb 7, 2025
+88 −1

Conversation

rcmadhankumar
Copy link
Contributor

[CI:TOXENVS] kubectl

@rcmadhankumar rcmadhankumar changed the title [WIP] test case add for kubectl container [WIP] test case added for kubectl container Dec 19, 2024
dcermak
dcermak reviewed Dec 19, 2024
View reviewed changes
bci_tester/data.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Dec 19, 2024
View reviewed changes
tests/test_kubectl.py Outdated Show resolved Hide resolved
alexandrevicenzi
alexandrevicenzi reviewed Jan 2, 2025
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
tests/test_kubectl.py Outdated Show resolved Hide resolved
@rcmadhankumar rcmadhankumar changed the title [WIP] test case added for kubectl container test case added for kubectl container Feb 3, 2025
@rcmadhankumar rcmadhankumar force-pushed the kubectl-tests branch 2 times, most recently from 55b2f3b to a864195 Compare February 3, 2025 11:46
dcermak
dcermak reviewed Feb 3, 2025
View reviewed changes
tests/test_kubectl.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Feb 3, 2025
View reviewed changes
tests/test_kubectl.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Feb 3, 2025
View reviewed changes
tests/test_kubectl.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Feb 3, 2025
View reviewed changes
tests/test_kubectl.py Outdated Show resolved Hide resolved
dcermak
dcermak requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase

@rcmadhankumar rcmadhankumar force-pushed the kubectl-tests branch 2 times, most recently from b88b91d to a1645ea Compare February 5, 2025 07:52
dcermak
dcermak requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update tests/test_metadata.py as well

tests/test_kubectl.py Outdated Show resolved Hide resolved
tests/test_kubectl.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Feb 5, 2025
View reviewed changes
bci_tester/data.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Feb 5, 2025
View reviewed changes
tests/test_kubectl.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Feb 5, 2025
View reviewed changes
bci_tester/data.py Outdated Show resolved Hide resolved
@dcermak
Copy link
Collaborator

dcermak commented Feb 5, 2025

and you need to add the following markers to pyproject.toml:

    'kubectl_1.28',
    'kubectl_1.29',
    'kubectl_1.30',
    'kubectl_1.31',

@rcmadhankumar rcmadhankumar force-pushed the kubectl-tests branch 2 times, most recently from 278eaad to e3a1668 Compare February 5, 2025 08:58
alexandrevicenzi
alexandrevicenzi requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@alexandrevicenzi alexandrevicenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is broken, please take a look

@rcmadhankumar
Copy link
Contributor Author

Meta data tests fix: SUSE/BCI-dockerfile-generator#2247

dcermak
dcermak requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to insert the KUBECTL_CONTAINERS into CONTAINERS_WITHOUT_ZYPPER (line 1081 in bci_tester/data.py)

bci_tester/data.py Outdated Show resolved Hide resolved
@rcmadhankumar rcmadhankumar force-pushed the kubectl-tests branch 3 times, most recently from b6fb56a to 5eb6f6d Compare February 7, 2025 08:00
dcermak
dcermak approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good now!

@dcermak dcermak merged commit a83d958 into main Feb 7, 2025
51 of 52 checks passed
@dcermak dcermak deleted the kubectl-tests branch February 7, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrevicenzi alexandrevicenzi alexandrevicenzi requested changes

@dcermak dcermak dcermak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcmadhankumar @dcermak @alexandrevicenzi