Feat: Optimize error logging on error in PerceptionClassesFilter

SUTURO · Sep 1, 2023 · 230736a · 230736a
1 parent 916367e
commit 230736a
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/src/main/java/com/malte3d/suturo/knowledge/owl2anything/output/PerceptionClassesFilter.java b/src/main/java/com/malte3d/suturo/knowledge/owl2anything/output/PerceptionClassesFilter.java
@@ -1,8 +1,6 @@
 package com.malte3d.suturo.knowledge.owl2anything.output;
 
-import java.util.Comparator;
-import java.util.HashSet;
-import java.util.List;
+import java.util.*;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.stream.Stream;
 
@@ -79,27 +77,34 @@ private static void checkForIncompleteIds(List<OwlRecord> records) {
                 .toList();
 
         if (!incompleteRecords.isEmpty())
-            throw new IllegalStateException("Classes without Id found: " + incompleteRecords);
+            throw new IllegalStateException("Classes without Id found: " +  generateRecordsList(incompleteRecords));
 
         boolean isSortedAndContinuous = records.stream()
                 .mapToInt(OwlRecord::getPerceptionId)
                 .reduce((int a, int b) -> b == (a + 1) ? b : Integer.MIN_VALUE)
                 .orElse(Integer.MIN_VALUE) != Integer.MIN_VALUE;
 
         if (!isSortedAndContinuous)
-            throw new IllegalStateException("Ids are not continuously increasing: " + records);
+            throw new IllegalStateException("Ids are not continuously increasing: " + generateRecordsList(records));
     }
 
     private static void checkForDuplicates(List<OwlRecord> records) {
 
-        HashSet<Integer> seen = new HashSet<>(records.size());
-        HashSet<OwlRecord> duplicate = new HashSet<>();
+        Set<Integer> seen = new HashSet<>(records.size());
+        Set<OwlRecord> duplicate = new HashSet<>();
 
         for (OwlRecord csvRecord : records)
             if (!seen.add(csvRecord.getPerceptionId()))
                 duplicate.add(csvRecord);
 
         if (!duplicate.isEmpty())
-            throw new IllegalStateException("Duplicate perception Ids found: " + duplicate);
+            throw new IllegalStateException("Duplicate perception Ids found: " + generateRecordsList(duplicate));
+    }
+
+    /**
+     * @return A string containing the records in the format "iriName: perceptionId" separated by a new line
+     */
+    private String generateRecordsList(Collection<OwlRecord> records) {
+        return String.join("\n", records.stream().map(record -> record.getIriName() + ": " + record.getPerceptionId()).toList());
     }
 }