Add RealArcade detection #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #280 |
mnadareski
reviewed
Apr 16, 2024
Comment on lines
+266
to
+272
| if (magic.StartsWith(new byte?[] { 0x52, 0x41, 0x53, 0x47, 0x49, 0x32, 0x2E, 0x30 })) | ||
| return SupportedFileType.RealArcadeInstaller; | ||
|
|
||
| // XZip2.0 | ||
| // Found in the ".mez" files in IA item "Nova_RealArcadeCD_USA". | ||
| if (magic.StartsWith(new byte?[] { 0x58, 0x5A, 0x69, 0x70, 0x32, 0x2E, 0x30 })) | ||
| return SupportedFileType.RealArcadeMezzanine; |
There was a problem hiding this comment.
Do these need full models? Or is just the magic number known?
There was a problem hiding this comment.
Full models would be ideal at some point, and would allow for better parsing of data such as game ID (which is present in plaintext toward the start of the file), but isn't really needed by any means.
mnadareski
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.