fix(openchallenges): correct the function name to trigger full text search on filters #2760
Conversation
|
There was a problem hiding this comment.
The fix works but I noticed that there may be a race condition that leads the list to include incorrect results.
Screencast 1: a result with the term "SA" is left in the list of results after updating the search terms "sa" to "sage".
Screencast 2: the results seem to show all the organization as if no search terms was provided, or as if the search for "sage" for ignored or overwritten.
Screencast 3:
@rrchai Is a race condition possible based on your knowledge of the implementation? If there's an easy fix we could package it with this PR. Otherwise, this PR contributes to increasing the quality of OC so I'm OK shipping it as is.
|
Merging this PR despite the race condition issue because it significantly reduces the impact of the original bug. @rrchai Please create a new ticket for the race condition issue I described above. |
The cause of the bug was using the wrong function name to trigger the full-text search on the corresponding filter.
Preview