Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agora): initial migration of packages and services (AG-1532) #2785

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

sagely1
Copy link
Contributor

@sagely1 sagely1 commented Aug 30, 2024

Description

Initial migration of Agora services

Changelog

Added packages for services:

  • sanitize-html package
  • rollbar

Updated package:

  • @types/node

Added Agora services:

  • ErrorService
  • HelperService
  • RollbarService
  • SynapseApiService

Testing / Validation

Run all unit tests:
nx run-many -t test --parallel=5

Run agora service unit tests:
nx test agora-services

@sagely1 sagely1 changed the title Initial migration of packages, services feat(Agora) Initial migration of packages, services Aug 30, 2024
@sagely1 sagely1 changed the title feat(Agora) Initial migration of packages, services feat(Agora): Initial migration of packages, services Aug 30, 2024
@sagely1 sagely1 changed the title feat(Agora): Initial migration of packages, services feat(agora): Initial migration of packages, services Aug 30, 2024
@sagely1 sagely1 changed the title feat(agora): Initial migration of packages, services feat(agora): Initial migration of packages and services Aug 30, 2024
@sagely1 sagely1 changed the title feat(agora): Initial migration of packages and services feat(agora): Initial migration of packages and services (AG-1532) Aug 30, 2024
@sagely1 sagely1 changed the title feat(agora): Initial migration of packages and services (AG-1532) feat(agora): initial migration of packages and services (AG-1532) Aug 30, 2024
@sagely1 sagely1 marked this pull request as ready for review August 30, 2024 19:37
@sagely1 sagely1 requested review from a team and tschaffter as code owners August 30, 2024 19:37
@tschaffter
Copy link
Member

Run all unit tests:

@sagely1 Documented command should be passed via nx as much as possible to benefit from it (e.g. caching). Instead of suggesting to run jest, you could suggest nx test agora-services.

@sagely1
Copy link
Contributor Author

sagely1 commented Aug 30, 2024

Run all unit tests:

@sagely1 Documented command should be passed via nx as much as possible to benefit from it (e.g. caching). Instead of suggesting to run jest, you could suggest nx test agora-services.

Will do! I've updated the PR and README.md

@sagely1 sagely1 requested a review from tschaffter August 30, 2024 22:52
@tschaffter tschaffter merged commit d07f4df into Sage-Bionetworks:main Aug 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants