Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openchallenges): implement UI suggestions from Stockard #2952

Merged
merged 6 commits into from
Dec 19, 2024
Merged

fix(openchallenges): implement UI suggestions from Stockard #2952

merged 6 commits into from
Dec 19, 2024

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Dec 19, 2024

Completes #2726

Changelog

  • Hide metrics from profile pages , at least until they're implemented
  • Remove "Awesome ...." cards from Organizers and Members sections of the profile pages
  • General linting for the styling sheets

These suggestions were implemented in order to increase the professionalism of the app.

Preview

Before
Screenshot 2024-12-18 at 3 58 39 PM
Screenshot 2024-12-18 at 3 58 30 PM

After
Screenshot 2024-12-18 at 3 58 12 PM
Screenshot 2024-12-18 at 3 57 12 PM

@vpchung vpchung self-assigned this Dec 19, 2024
@vpchung vpchung linked an issue Dec 19, 2024 that may be closed by this pull request
[Feedback] UI suggestions #2726
Closed
1 task
tschaffter
tschaffter approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tschaffter tschaffter merged commit 3abb320 into Sage-Bionetworks:main Dec 19, 2024
13 checks passed
@vpchung vpchung deleted the fix-ui-updates branch January 7, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter tschaffter approved these changes

@rrchai rrchai Awaiting requested review from rrchai rrchai is a code owner

Assignees

@vpchung vpchung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feedback] UI suggestions
2 participants
@vpchung @tschaffter