chore(agora): use edge for app version and tag name placeholder, update data version to align with agora-data-manger (AG-1681) #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallieswan
force-pushed
the
agora/AG-1681
branch
from
559443a to
dad187d
Compare
hallieswan
had a problem deploying
to
agora-pr
GitHub Actions
Failure
hallieswan
force-pushed
the
agora/AG-1681
branch
from
dad187d to
6cdb3c4
Compare
Merged
via the queue into
Sage-Bionetworks:main
with commit Feb 21, 2025
c506775
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
agora-appdisplays two values for the Site Version in the footer: an app version and a commit SHA (looked up using a tag name). These values are set to the current release in the infra code. However, keeping the example values in.env.exampleandconfig.jsonaligned with the actual latest release adds extra overhead. Instead, we would like to use "edge" as the placeholder in these files.Separately, the data manifest version was recently updated in agora-data-manager. This PR updates the
agora-datavalue to match.Related Issues
Validation
Update
APP_VERSIONandTAG_NAMEinapps/agora/app/.envto match the values in.env.example.Update
DATA_VERSIONinapps/agora/data.envto "72".Run agora:
agora-build-images && nx run agora-apex:serve-detach.View the footer:
Note: since "edge" is not a git tag in sage-monorepo, the commit SHA is not displayed in the footer. The dev can change the value to an actual git tag if they would like to see the SHA displayed.