test(progress-tracker): convert tests to playwright - FE-6150 #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c0331a4:
|
ZhuoyuJin
reviewed
Nov 28, 2023
| ); | ||
| }); | ||
|
|
||
| ([[true], [false]] as const).forEach(([boolean]) => { |
There was a problem hiding this comment.
Suggested change
| ([[true], [false]] as const).forEach(([boolean]) => { | |
| ([true, false] as const).forEach(([boolean]) => { |
ZhuoyuJin
reviewed
Nov 28, 2023
| }); | ||
| }); | ||
|
|
||
| test.describe( |
There was a problem hiding this comment.
(non-blocking):
Suggested change
| test.describe( | |
| test.describe("Accessibility tests", () => { |
ZhuoyuJin
reviewed
Nov 28, 2023
| @@ -0,0 +1,21 @@ | |||
| import type { Page } from "@playwright/test"; | |||
There was a problem hiding this comment.
Suggested change
| import type { Page } from "@playwright/test"; | |
| import { Page } from "@playwright/test"; |
ZhuoyuJin
previously approved these changes
Nov 29, 2023
Parsium
reviewed
Nov 30, 2023
| @@ -152,6 +152,7 @@ const ProgressTracker = ({ | |||
| error={error} | |||
| > | |||
| <InnerBar | |||
| data-element="inner-bar" | |||
There was a problem hiding this comment.
praise: like the addition of a new test tag for greater specificity
Parsium
reviewed
Dec 1, 2023
Parsium
approved these changes
Dec 5, 2023
ZhuoyuJin
approved these changes
Dec 5, 2023
DipperTheDan
force-pushed
the
FE-6150_progress-tracker-pw-refactor
branch
from
de60578 to
1e7883d
Compare
|
🎉 This PR is included in version 124.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Reactor tests to use Playwright.
Current behaviour
Tests currently use Cypress.
Checklist
d.tsfile added or updated if requiredQA
Additional context
N/A
Testing instructions
N/A