Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(typography): convert test to playwright - FE-6169 #6460

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

DipperTheDan
Copy link
Contributor

Proposed behaviour

Tests should use Playwright

Current behaviour

Tests use Cypress

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Cypress automation tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in CodeSandbox/storybook
  • Add new Cypress test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

N/A

Copy link

codesandbox-ci bot commented Nov 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d50a29a:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

@robinzigmond robinzigmond self-requested a review December 4, 2023 08:57
src/components/typography/components.test-pw.tsx Outdated Show resolved Hide resolved
src/components/typography/components.test-pw.tsx Outdated Show resolved Hide resolved
src/components/typography/typography.pw.tsx Outdated Show resolved Hide resolved
src/components/typography/typography.pw.tsx Outdated Show resolved Hide resolved
src/components/typography/typography.pw.tsx Outdated Show resolved Hide resolved
src/components/typography/typography.pw.tsx Outdated Show resolved Hide resolved
src/components/typography/typography.pw.tsx Outdated Show resolved Hide resolved
@DipperTheDan DipperTheDan force-pushed the FE-6169_typography-pw-refactor branch 2 times, most recently from abf7bc4 to 0508c7f Compare December 4, 2023 11:11
@DipperTheDan DipperTheDan marked this pull request as ready for review December 5, 2023 10:53
@DipperTheDan DipperTheDan requested a review from a team as a code owner December 5, 2023 10:53
@DipperTheDan DipperTheDan force-pushed the FE-6169_typography-pw-refactor branch from 0508c7f to d50a29a Compare December 5, 2023 13:39
@DipperTheDan DipperTheDan merged commit b7d41d7 into master Dec 5, 2023
@DipperTheDan DipperTheDan deleted the FE-6169_typography-pw-refactor branch December 5, 2023 15:00
@carbonci
Copy link
Collaborator

carbonci commented Dec 6, 2023

🎉 This PR is included in version 124.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants