test(switch): convert tests to playwright #6470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 67dfa18:
|
DipperTheDan
reviewed
Dec 6, 2023
src/components/switch/switch.pw.tsx
Outdated
| }); | ||
|
|
||
| ([SIZE.SMALL, SIZE.LARGE] as SwitchProps["size"][]).forEach((size) => { | ||
| test(`check accessibility with size sets to ${size}`, async ({ |
There was a problem hiding this comment.
Suggested change
| test(`check accessibility with size sets to ${size}`, async ({ | |
| test(`check accessibility with size set to ${size}`, async ({ |
stephenogorman
requested changes
Dec 7, 2023
src/components/switch/switch.pw.tsx
Outdated
| }); | ||
| }); | ||
|
|
||
| test("should verify with data-component", async ({ mount, page }) => { |
There was a problem hiding this comment.
Suggested change
| test("should verify with data-component", async ({ mount, page }) => { | |
| test("should render with data-component", async ({ mount, page }) => { |
src/components/switch/switch.pw.tsx
Outdated
| ); | ||
| }); | ||
|
|
||
| test("should verify with data-element", async ({ mount, page }) => { |
There was a problem hiding this comment.
Suggested change
| test("should verify with data-element", async ({ mount, page }) => { | |
| test("should render with data-element", async ({ mount, page }) => { |
src/components/switch/switch.pw.tsx
Outdated
| ); | ||
| }); | ||
|
|
||
| test("should verify with data-role", async ({ mount, page }) => { |
There was a problem hiding this comment.
Suggested change
| test("should verify with data-role", async ({ mount, page }) => { | |
| test("should render with data-role", async ({ mount, page }) => { |
src/components/switch/switch.pw.tsx
Outdated
| }); | ||
|
|
||
| [true, false].forEach((boolVal) => { | ||
| test(`should render when fieldHelpInline sets to ${boolVal}`, async ({ |
There was a problem hiding this comment.
Suggested change
| test(`should render when fieldHelpInline sets to ${boolVal}`, async ({ | |
| test(`should render with fieldHelpInline set to ${boolVal}`, async ({ |
src/components/switch/switch.pw.tsx
Outdated
| }); | ||
|
|
||
| ["error", "warning", "info"].forEach((validation) => { | ||
| test(`should render with ${validation} validation icon`, async ({ |
There was a problem hiding this comment.
Suggested change
| test(`should render with ${validation} validation icon`, async ({ | |
| test(`should render with ${validation} validation icon`, async ({ |
src/components/switch/switch.pw.tsx
Outdated
| [SIZE.LARGE, 82, 44], | ||
| ] as [SwitchProps["size"], number, number][]).forEach( | ||
| ([size, width, height]) => { | ||
| test(`should render with size sets to ${size}`, async ({ |
There was a problem hiding this comment.
Suggested change
| test(`should render with size sets to ${size}`, async ({ | |
| test(`should render with size set to ${size}`, async ({ |
src/components/switch/switch.pw.tsx
Outdated
| }); | ||
|
|
||
| [true, false].forEach((boolVal) => { | ||
| test(`check accessibility with loading prop is ${boolVal}`, async ({ |
There was a problem hiding this comment.
Suggested change
| test(`check accessibility with loading prop is ${boolVal}`, async ({ | |
| test(`check accessibility when loading prop is ${boolVal}`, async ({ |
src/components/switch/switch.pw.tsx
Outdated
| }); | ||
| }); | ||
|
|
||
| test("check accessibility with data-component prop sets", async ({ |
There was a problem hiding this comment.
Suggested change
| test("check accessibility with data-component prop sets", async ({ | |
| test("check accessibility with data-component prop set", async ({ |
There was a problem hiding this comment.
This comment can be applied to each test which has prop sets
src/components/switch/switch.pw.tsx
Outdated
| }); | ||
|
|
||
| [true, false].forEach((boolVal) => { | ||
| test(`check accessibility with defaultChecked is ${boolVal}`, async ({ |
There was a problem hiding this comment.
Suggested change
| test(`check accessibility with defaultChecked is ${boolVal}`, async ({ | |
| test(`check accessibility when defaultChecked is ${boolVal}`, async ({ |
src/components/switch/switch.pw.tsx
Outdated
| }); | ||
| }); | ||
|
|
||
| test("check accessibility for with Margin example", async ({ |
There was a problem hiding this comment.
Suggested change
| test("check accessibility for with Margin example", async ({ | |
| test("check accessibility for WithMargin example", async ({ |
ZhuoyuJin
force-pushed
the
playwright_refactor_switch
branch
from
b4b83a9 to
960490c
Compare
stephenogorman
approved these changes
Dec 8, 2023
DipperTheDan
approved these changes
Dec 8, 2023
ZhuoyuJin
force-pushed
the
playwright_refactor_switch
branch
from
38e5cb2 to
67dfa18
Compare
|
🎉 This PR is included in version 124.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Reactor tests to use Playwright.
Current behaviour
Tests currently use Cypress.
Checklist
d.tsfile added or updated if requiredQA
Additional context
N/A
Testing instructions
N/A