feat(menu-fullscreen): fix colours when MenuItem used as child of MenuSegmentTitle #7097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienrobson-sage
force-pushed
the
FE-6679-menufullscreen-variants
branch
from
edb3d70 to
4dc8547
Compare
DipperTheDan
previously approved these changes
Nov 29, 2024
mihai-albu-sage
previously approved these changes
Dec 2, 2024
damienrobson-sage
dismissed stale reviews from mihai-albu-sage and DipperTheDan
via
d495f7a
damienrobson-sage
force-pushed
the
FE-6679-menufullscreen-variants
branch
from
4dc8547 to
d495f7a
Compare
mihai-albu-sage
previously approved these changes
Dec 6, 2024
DipperTheDan
previously approved these changes
Dec 6, 2024
damienrobson-sage
dismissed stale reviews from DipperTheDan and mihai-albu-sage
via
eb2a530
damienrobson-sage
force-pushed
the
FE-6679-menufullscreen-variants
branch
from
d495f7a to
eb2a530
Compare
paulrobinson88
previously approved these changes
Dec 9, 2024
DipperTheDan
previously approved these changes
Dec 9, 2024
damienrobson-sage
dismissed stale reviews from DipperTheDan and paulrobinson88
via
7b6ae46
damienrobson-sage
force-pushed
the
FE-6679-menufullscreen-variants
branch
from
eb2a530 to
7b6ae46
Compare
paulrobinson88
approved these changes
Dec 10, 2024
DipperTheDan
approved these changes
Dec 10, 2024
mihai-albu-sage
approved these changes
Dec 10, 2024
|
🎉 This PR is included in version 144.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Adds context to
MenuSegmentTitlewhich allowsMenuItemto know if the wrapping parent element is aMenuSegmentTitleand if so, override the colouring. Additional changes have also been implemented to ensure that this only happens whenMenuFullscreenis used - normalMenuitems are unaffected.Current behaviour
When used as a child of
MenuSegmentTitlewith thealternatevariant, the wrong colouring is applied toMenuItemChecklist
QA
Additional context
Resolves 6789
Testing instructions
Use the new Menu Storybook entry to verify the changes work and do not impact other menus