-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dialog): ensure enableBackgroundUI is passed to Modal #7167
Conversation
fda0778
to
7492429
Compare
3ad1dae
to
d6b9d2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're almost there, the spreading rest approach does work, and enableBackgroundUI
will be passed down to the modal component. I'd just have a look at my other comments, as we can probably remove changes in 5 files total, and keep the changes limited to dialog.
I think adding some sort of test to verify the prop works, and create a baseline for the changes made would be beneficial. I'd take a look at the first playwright test in the sidebar pw file 👍
src/components/dialog-full-screen/dialog-full-screen.stories.tsx
Outdated
Show resolved
Hide resolved
src/components/popover-container/popover-container-test.stories.tsx
Outdated
Show resolved
Hide resolved
3ffbec5
to
b1f1791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @DobroTora,
Happy to approve when the tests are moved into the correct describe block 👍
0f45777
🎉 This PR is included in version 147.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fix #6023
adding modal props to Dialog and pass enableBackgroundUI
Proposed behaviour
Current behaviour
Checklist
d.ts
file added or updated if requiredQA
Additional context
Testing instructions