-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search, menu-item): Search accessibility updates #7186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffa4f4d
to
8941367
Compare
mihai-albu-sage
previously approved these changes
Jan 31, 2025
edleeks87
reviewed
Jan 31, 2025
edleeks87
previously approved these changes
Feb 3, 2025
Did a UXQA and A11y review at desk with Accessibility team, so looks good to us. |
…rom aria, esc clears search resolves #7170
6cd605f
8941367
to
6cd605f
Compare
dariusbercea-sage
approved these changes
Feb 6, 2025
mihai-albu-sage
approved these changes
Feb 6, 2025
🎉 This PR is included in version 147.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can clear the text of the search box using the keyboard/voice commands; as such, the clear button in the search input is being read out to non-visual users unnecessarily and can be removed from the tab order. It also does not need to be focusable. In order to enhance this component further, functionality has been introduced to allow users to clear the Search field with the Escape key, which is standard practice across the web.
Resolves #7170
Proposed behaviour
aria-hidden
attribute to the clear button;Screen.Recording.2025-01-30.at.06.58.51.mov
Screen.Recording.2025-01-30.at.06.56.37.mov
Current behaviour
The "clear" icon is tabbable and read out by screen readers, and the search input cannot be cleared by expected means.
Screen.Recording.2025-01-30.at.06.56.02.mov
Checklist
d.ts
file added or updated if requiredQA