footer added #47
Open
footer added #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for books-mall pending review.Visit the deploys page to approve it
|
|
@JSuhas123 is attempting to deploy a commit to the sahil-gupta584's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@JSuhas123 footer looking nice but for well structured codebase try to make a saperate componenet in component folders, and try to use icons or svg tags for social icons instead images as it occupies more storage |
|
Yeah , will change it soon @Sahil-Gupta584 |
1 similar comment
|
Yeah , will change it soon @Sahil-Gupta584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Sahil-Gupta584 the footer is added, can you please merge the pr.
