Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Compat and Change MalignantCoversion Work #349

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

Tctiancan
Copy link
Contributor

If ignore base value, the base value no longer be converted/consume.

@SammySemicolon
Copy link
Owner

Seems good, could you mirror it to the 1.21 branch?

@SammySemicolon SammySemicolon merged commit edaa0a9 into SammySemicolon:1.6-1.20.1 Feb 20, 2025
1 check failed
@SammySemicolon
Copy link
Owner

What's the purpose of the changes in MalignantConversionHandler? They mess with the math in weird ways it seems.

@Tctiancan
Copy link
Contributor Author

What's the purpose of the changes in MalignantConversionHandler? They mess with the math in weird ways it seems.

Before, if the base value was 1, MalignantConversion was 0.5, and the value was 1.2, only the 0.2 * 0.5 part increased the target value, but the source attribute multiplied by 50% (1.2 * 0.5 = 0.6), even lower than the base value.
After modification, the source attribute only reduces the part involved in conversion, 0.2 / 1.2 = 1/6, 1.2 * 5/6 * 0.5 = 1.1

@SammySemicolon
Copy link
Owner

I think the math might be a little off, from my quick testing the change caused regular values to no longer be modified properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants