Fix validation edge case when function end code is missing #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
approved these changes
Jan 24, 2025
test/basic/missing_end.wast
Outdated
| "\0b" ;; end | ||
| ) | ||
| "function body must end with END opcode" | ||
| ) |
test/basic/missing_end.wast
Outdated
| @@ -0,0 +1,28 @@ | |||
| (assert_invalid | |||
| (module binary | |||
| "\00\61\73\6d\01\00\00\00" | |||
There was a problem hiding this comment.
The spec-core tests use ascii characters here.
matetokodi
force-pushed
the
fix_missing_end
branch
from
4869fab to
9788b4c
Compare
|
ARM64 compiler randomly crashes, I don't know the reason. If you repush the patch, it will eventually fix. |
In some cases `m_resumeGenerateByteCodeAfterNBlockEnd` could be non-zero when the preprocessing is finished on invalid wasm code. Signed-off-by: Máté Tokodi [email protected]
matetokodi
force-pushed
the
fix_missing_end
branch
from
9788b4c to
900f5ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
m_resumeGenerateByteCodeAfterNBlockEndcould be non-zero when the preprocessing is finished on invalid wasm code.