-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(php) - sending emails #2903
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you tested this code? If yes and you confirm it's working, then LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether documenting a specific framework is really what we want to do (because maintenance, etc.)
Also, we should probably advise to use Composer to install the dependency, like so:
composer require phpmailer/phpmailer
@Frzk I actually agree.. do you think it would be ok to remove the sample? |
Co-authored-by: Étienne M. <[email protected]>
Co-authored-by: Étienne M. <[email protected]>
I agree with @Frzk Why Brevo specifically? |
Fixes #1085
This PR adds some basic information about sending emails from PHP, and an example using Brevo.