Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(php) - sending emails #2903

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

sc-zenokerr
Copy link
Contributor

@sc-zenokerr sc-zenokerr commented Dec 10, 2024

Fixes #1085

This PR adds some basic information about sending emails from PHP, and an example using Brevo.

image

@sc-zenokerr sc-zenokerr self-assigned this Dec 10, 2024
@sc-zenokerr sc-zenokerr requested a review from EtienneM December 10, 2024 10:17
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you tested this code? If yes and you confirm it's working, then LGTM :)

src/_posts/languages/php/2000-01-01-sending-emails.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Frzk Frzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether documenting a specific framework is really what we want to do (because maintenance, etc.)

Also, we should probably advise to use Composer to install the dependency, like so:

composer require phpmailer/phpmailer

src/_posts/languages/php/2000-01-01-sending-emails.md Outdated Show resolved Hide resolved
@sc-zenokerr
Copy link
Contributor Author

@Frzk I actually agree.. do you think it would be ok to remove the sample?
It is difficult to test in anycase (without us having an account with Brevo)

@sc-zenokerr sc-zenokerr requested a review from Frzk December 11, 2024 16:37
@aurelien-reeves-scalingo
Copy link
Contributor

I agree with @Frzk

Why Brevo specifically?
Specially as this is just regular SMTP here. There is no need to limit the case to Brevo IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP] Document how to send emails with PHP
4 participants