Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defaults and ensureTypes generation #85

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix defaults and ensureTypes generation #85

merged 3 commits into from
Jul 30, 2024

Conversation

cyrillhalter
Copy link
Collaborator

  • Makes sure defaults are handled properly
  • reverts some new logic in the ensuretypes function that lead to excessive overhead
  • adds proper test coverage for getters and setters
  • ensures consistent handling of type conversion errors

@cyrillhalter cyrillhalter requested review from sbra0902, sden1403, mpradzin and a team as code owners July 24, 2024 14:36
@cyrillhalter cyrillhalter merged commit edde4bd into SchwarzIT:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-wolf-ergon marco-wolf-ergon marco-wolf-ergon approved these changes

@sbra0902 sbra0902 Awaiting requested review from sbra0902 sbra0902 is a code owner

@sden1403 sden1403 Awaiting requested review from sden1403 sden1403 is a code owner

@mpradzin mpradzin Awaiting requested review from mpradzin mpradzin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyrillhalter @marco-wolf-ergon @cyrill-halter-ergon