Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic material table #1735

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Jan 31, 2025

Description

Add dynamic material table to the proposals dashboard, replacing the old table. This table should add more flexibility and it includes some new features like reordering of columns, resizing of columns and hide/show columns feature.

New Features:

Display proposals using the new dynamic material table.

Motivation

This table should be the new shared table across all the SciCat frontend. The point is to start with proposals and test it there.

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • introducing of the new dynamic material table
  • replacing the proposals table with the new table

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Add dynamic material table to the proposals dashboard, replacing the old table. Include related proposals and datasets in separate tabs.

New Features:

  • Display related proposals on the proposal details page.

Tests:

  • Update tests for view-proposal-page component.

Summary by Sourcery

Replace the old proposals table with a new dynamic material table.

New Features:

  • Introduce a dynamic material table for proposals, providing enhanced flexibility.

Tests:

  • Update Cypress tests to reflect the changes in the table implementation.

martin-trajanovski and others added 30 commits January 13, 2025 16:29
@martin-trajanovski martin-trajanovski marked this pull request as ready for review February 9, 2025 14:36
@martin-trajanovski martin-trajanovski added DCS DAPHNE Contribution to SciCat feature labels Feb 9, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martin-trajanovski - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting common utility functions (e.g., null checks or repeated RxJS patterns) into dedicated utility modules to streamline and simplify maintenance.
  • Add inline comments or brief documentation in the more complex areas (like virtual scroll and filter logic) to aid future maintainers in understanding the component flow.
Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants