-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamic material table #1735
Open
martin-trajanovski
wants to merge
37
commits into
master
Choose a base branch
from
add-dynamic-material-table
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
…tProject/frontend into add-dynamic-material-table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martin-trajanovski - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting common utility functions (e.g., null checks or repeated RxJS patterns) into dedicated utility modules to streamline and simplify maintenance.
- Add inline comments or brief documentation in the more complex areas (like virtual scroll and filter logic) to aid future maintainers in understanding the component flow.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
...pp/shared/modules/dynamic-material-table/table/extensions/table-menu/table-menu.component.ts
Show resolved
Hide resolved
...app/shared/modules/dynamic-material-table/table/extensions/filter/header-filter.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/modules/dynamic-material-table/cores/dynamic-pipe.pipe.ts
Outdated
Show resolved
Hide resolved
src/app/proposals/proposal-dashboard/proposal-dashboard.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/modules/dynamic-material-table/cores/table-data-source.ts
Show resolved
Hide resolved
src/app/shared/modules/dynamic-material-table/table/dynamic-mat-table.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add dynamic material table to the proposals dashboard, replacing the old table. This table should add more flexibility and it includes some new features like reordering of columns, resizing of columns and hide/show columns feature.
New Features:
Display proposals using the new dynamic material table.
Motivation
This table should be the new shared table across all the SciCat frontend. The point is to start with proposals and test it there.
Fixes:
Please provide a list of the fixes implemented in this PR
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Add dynamic material table to the proposals dashboard, replacing the old table. Include related proposals and datasets in separate tabs.
New Features:
Tests:
Summary by Sourcery
Replace the old proposals table with a new dynamic material table.
New Features:
Tests: