-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a separate package BayesianNeuralPDE.jl #920
base: master
Are you sure you want to change the base?
Conversation
The CI failed showing some python distutils error |
@ChrisRackauckas The BayesianNeuralPDE part has been split into a separate package. Do I also need to make respective changes in the docs ? because the current documentation tests would likely fail on the CI while the others pass |
The tests that failed are based on documentation. Should I make changes to that too?? |
@@ -22,6 +22,7 @@ IntervalSets = "8197267c-284f-5f27-9208-e0e47529a953" | |||
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" | |||
LogDensityProblems = "6fdf6af0-433a-55f7-b3ed-c6c6e0b8df7c" | |||
Lux = "b2108857-7c20-44ae-9111-449ecde12c47" | |||
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because, when I precompiled NeuralPDE, it gave me an error saying this dependency is required for NeuralPDE but not found in its dependencies section
@info "Running tests with $(RETESTITEMS_NWORKERS) workers and \ | ||
$(RETESTITEMS_NWORKER_THREADS) threads for group $(GROUP)" | ||
|
||
ReTestItems.runtests(NeuralPDE; tags = (GROUP == "all" ? nothing : [Symbol(GROUP)]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be BayesainNeuralPDE? Also, this might not be tested at all in CI. Look at how its done in OrdinaryDiffEq or some other where there are subpackages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I will see to it
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.