Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stirling-pdf: Update to version 0.36.5 #14651

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

Jin1c-3
Copy link
Contributor

@Jin1c-3 Jin1c-3 commented Dec 29, 2024

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

stirling-pdf

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@rasa rasa merged commit 9b01527 into ScoopInstaller:master Dec 29, 2024
1 check passed
@Absolves
Copy link
Contributor

Failed to create shortcut
image

@Absolves
Copy link
Contributor

I think it still needs to be adjusted @Jin1c-3

@Jin1c-3
Copy link
Contributor Author

Jin1c-3 commented Jan 4, 2025

I can't resolve this issue: in versions 0.36.4 and earlier of the Stirling-pdf repository, the release contains a portable version named stirling-pdf.exe. However, this portable version is absent in versions 0.35.5 and later. I also tried using innounp, but it does not support the Stirling-pdf installation package. Can you help resolve this problem?

I think it still needs to be adjusted @Jin1c-3

@milnak
Copy link

milnak commented Jan 6, 2025

I looked into this. The portable app is now "Stirling-PDF-Server.exe". https://github.com/Stirling-Tools/Stirling-PDF/releases/download/v0.36.6/Stirling-PDF-Server.exe. Should be an easy manifest fix.

@Gestrid
Copy link

Gestrid commented Jan 15, 2025

Copying my comment from the above linked related issue:

This still seems to be an issue. v0.37.0 was just released to Scoop, and the issue hasn't been fixed.

Log of the attempted install below:

Installing 'stirling-pdf' (0.37.0) [64bit] from 'extras' bucket
Stirling-PDF-win-installer.exe (150.4 MB) [===================================================================] 100%
Checking hash of Stirling-PDF-win-installer.exe ... ok.
Linking ~\scoop\apps\stirling-pdf\current => ~\scoop\apps\stirling-pdf\0.37.0
Creating shortcut for Stirling-PDF (Stirling-PDF.exe) failed: Couldn't find C:\Users\[USER]\scoop\apps\stirling-pdf\current\Stirling-PDF.exe
Persisting configs
Persisting customFiles
Persisting logs
'stirling-pdf' (0.37.0) was installed successfully!

Obviously, the text at the bottom isn't true.

@Jin1c-3
Copy link
Contributor Author

Jin1c-3 commented Jan 15, 2025

I fixed this issue in pull request #14682 , but I am unsure why it has not been merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants