Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gephi: add version 0.9.2 #7806

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Conversation

tech189
Copy link
Member

@tech189 tech189 commented Jan 21, 2022

  • Closes [Request] Gephi #7794

  • Nothing to persist as config stored in C:\Users\username\AppData\Roaming\.gephi

  • Caveat: requires Java 1.8 to be installed - does NOT detect Java installed using any manifest in the Java bucket nor does it accept any higher Java version, should this be added as a note?

  • Java issue would probably be fixed by Adding Java path to registry Java#119 as at the moment Java manifests only add JAVA_HOME environment variable

  • I have read the Contributing Guide.

@rashil2000
Copy link
Member

/verify

should this be added as a note?

Add a suggest for Java 1.8 and a note that any other version won't work.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

gephi

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@tech189
Copy link
Member Author

tech189 commented Jan 21, 2022

Sorry I wasn't clear, I meant that it only works if Java 1.8 is installed from https://www.java.com/en/download/ (it probably only checks the registry), not through Scoop. So rather than a suggest should we put a note?

@rashil2000
Copy link
Member

Oh, okay. No suggest then.

Add the URL for Java 1.8 in the note too.

@tech189
Copy link
Member Author

tech189 commented Jan 21, 2022

Actually reading up a bit more I discovered the --jdkhome flag and the jdkhome= config in $dir\etc\gephi.conf which could be modified on installation to point to $env:JAVA_HOME! I tested it works with Scoop's Java manifests of oraclejre8 and liberica8-jdk (and maybe others) but definitely not openjdk because of the limitation of only Java 8 - for reference this is an issue being tracked in the Gephi repo: gephi/gephi#2160

I will write an installer script to modify the conf file a bit later today.

@tech189
Copy link
Member Author

tech189 commented Jan 21, 2022

How can I get the $env:JAVA_HOME variable while running in post_install? It is empty on installation but contains the right path normally in my terminal.

Here is the post_install so far:

"post_install": [
        "$conf_file = \"$dir\\etc\\gephi.conf\"",
        "((Get-Content -path $conf_file -Raw) -replace \"#jdkhome=`\"\/path\/to\/jdk`\"\", \"jdkhome=`\"$env:JAVA_HOME`\"\") | Set-Content -Path $conf_file\"\""
    ],

@rashil2000
Copy link
Member

You can do a Write-Host in the post_install script to test the value of any variables. It will print to the terminal.

@tech189
Copy link
Member Author

tech189 commented Jan 24, 2022

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

gephi

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@tech189
Copy link
Member Author

tech189 commented Jan 24, 2022

@rashil2000 It's all ready now! The post_install checks if the conf file has got the JAVA_HOME set already and if not, it will add the current JAVA_HOME environment variable :)

@rashil2000 rashil2000 merged commit 1eafee6 into ScoopInstaller:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Gephi
2 participants