Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vosviewer: add version 1.6.18 #8917

Merged
merged 6 commits into from
Jul 26, 2022
Merged

vosviewer: add version 1.6.18 #8917

merged 6 commits into from
Jul 26, 2022

Conversation

Lutra-Fs
Copy link
Contributor

@Lutra-Fs Lutra-Fs commented Jul 24, 2022 •
edited
Loading

Closes #8878

Relates to #XXXX

@Lutra-Fs

This comment was marked as resolved.

Sign in to view
@Lutra-Fs

This comment was marked as outdated.

Sign in to view
@Lutra-Fs Lutra-Fs marked this pull request as ready for review July 24, 2022 10:06
@Lutra-Fs
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

vosviewer

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Lutra-Fs
Copy link
Contributor Author

Update: I tried oraclejre8 in java bucket but it does not work

@Lutra-Fs

This comment was marked as resolved.

Sign in to view
@issaclin32
Copy link
Member

issaclin32 commented Jul 25, 2022 •
edited
Loading

Update: I tried oraclejre8 in java bucket but it does not work

seems like a full jre8 installation via https://www.java.com/en/download/ is required

Probably related to this issue: ScoopInstaller/Java#119

@Lutra-Fs

This comment was marked as resolved.

Sign in to view
@Lutra-Fs
Copy link
Contributor Author

Lutra-Fs commented Jul 25, 2022 •
edited
Loading

Update: I tried oraclejre8 in java bucket but it does not work

seems like a full jre8 installation via java.com/en/download is required

Probably related to this issue: ScoopInstaller/Java#119

Agreed. Just found that termuin jre installed via winget will not add Oracle Java related registry keys. After manually changing installation, it now worked as expected

@Lutra-Fs
Copy link
Contributor Author

Lutra-Fs commented Jul 25, 2022 •
edited
Loading

So maybe add a notes to ScoopInstaller/Java#119? Or waiting for java bucket to add support? but I have seen that there is no progress since 2020.

@issaclin32
Copy link
Member

So maybe add a notes to ScoopInstaller/Java#119? Or waiting for java bucket to add support? but as I have seen that there is no progress since 2020.

I think adding notes should be fine.

I am not an expert on Java. I am not really sure why Java bucket's maintainer did not solve that, maybe they have some other concerns.

@Lutra-Fs
Copy link
Contributor Author

So maybe add a notes to ScoopInstaller/Java#119? Or waiting for java bucket to add support? but as I have seen that there is no progress since 2020.

I think adding notes should be fine.

I am not an expert on Java. I am not really sure why Java bucket's maintainer did not solve that, maybe they have some other concerns.

Added

issaclin32
issaclin32 reviewed Jul 26, 2022
View reviewed changes
bucket/vosviewer.json Outdated Show resolved Hide resolved
@Lutra-Fs
Copy link
Contributor Author

Lutra-Fs commented Jul 26, 2022 •
edited
Loading

Should I remove jre suggestion in manifest?

@issaclin32
Copy link
Member

Should I remove jre suggestion in manifest?

Yes. Please remove it.

@issaclin32 issaclin32 merged commit 04eeafe into ScoopInstaller:master Jul 26, 2022
@Lutra-Fs Lutra-Fs deleted the vosviewer branch July 26, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issaclin32 issaclin32 issaclin32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] VOSviewer
2 participants
@Lutra-Fs @issaclin32