-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman: Add data/config/connections persist #6438
base: master
Are you sure you want to change the base?
Conversation
All changes look good. Wait for review from human collaborators. podman
|
bucket/podman.json
Outdated
"uninstaller": { | ||
"script": "Remove-Path -Path $dir -TargetEnvVar $scoopPathEnvVar -Global:$global -Force" | ||
}, | ||
"env_set": { | ||
"XDG_DATA_HOME": "$dir\\data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This environment variable will impact numerous other applications. Is there an alternative method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the doc, it is the most elegant way to config.
Or, I can use the method for config
persist directory, like L13 and L43-L46, which avoid the use of environment variable XDG_CONFIG_HOME
.
I implemented different methods because I'm not sure which is the preferred way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is advisable to avoid using XDG_CONFIG_HOME
imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, now all environment variables start with XDG_
are removed from this PR.
@niheaven Is there anything I can do to move this forward? Also, can you look at the other similar PR at ScoopInstaller/Extras#14697? |
@niheaven Is there anything I can do to move this forward? :) |
1 similar comment
@niheaven Is there anything I can do to move this forward? :) |
Add the ability to preserve and purge data/config/connections for Podman.
This PR also covered the migration process.
<manifest-name[@version]|chore>: <general summary of the pull request>