Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.8 fixes #6

Closed
wants to merge 1 commit into from
Closed

2.8 fixes #6

wants to merge 1 commit into from

Conversation

hsab
Copy link

@hsab hsab commented Dec 30, 2018

Minor fixes to make compatible with 2.8
Mainly change version number
Fix the to_mesh call based on new api

@ScottishCyclops
Copy link
Owner

Hey,

Thanks for your contribution !

I will merge it into a separate 2.8 Branch, because otherwise it would not be compatible with 2.79 anymore.

Have you tested it successful ?

Looking at your changes, your removed "settings="PREVIEW". However, it is important to apply the preview settings (and not the render settings) of the modifiers.
Did you remove it because it is the default behavior in 2.8 ?

Scott

@hsab
Copy link
Author

hsab commented Jan 9, 2019

Yes that function parameter is removed from the 2.8 API.

I tested successfully in 2.8 but there are some bug related to the internal code
JacquesLucke/animation_nodes#989

@ScottishCyclops ScottishCyclops requested review from ScottishCyclops and removed request for ScottishCyclops January 12, 2019 21:13
@ScottishCyclops
Copy link
Owner

I created a "2.8" Branch. I don't think I can accept your pull request into a branch other than the one you selected.
Could you make another pull request on the new 2.8 Branch ?

Thanks !

Scott

@ScottishCyclops
Copy link
Owner

Closed as I just uploaded a 2.8-complient version to the 2.8 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants