fix: update handling of query parameters and theming #35

nicomiguelino · 2025-01-28T16:53:23Z

Regardless of whether the srly query parameter is specified or not, the screenly-cast theme is being applied.

Fixes call to is_query() and is_main_query()
Updated the conditional statement so that the screenly-cast theme will only take effect if the srly query parameter is specified even if it doesn't have a set value

nicomiguelino added 4 commits January 28, 2025 08:34

fix: update handling of query parameters and theming

3a0e915

fix: revert to the previous theme instead of a fixed one

ce6915b

chore: refactor the code that switches back to the original theme

3893054

tests: fix broken unit tests

d4c8601

nicomiguelino requested a review from vpetersson January 28, 2025 20:20

nicomiguelino added 2 commits January 28, 2025 12:24

chore(ci): resolve linting issues

2a66d0b

chore(ci): resolve more linting errors

d2f36b9

vpetersson approved these changes Jan 28, 2025

View reviewed changes

nicomiguelino merged commit 311c549 into Screenly:master Jan 28, 2025
13 checks passed

nicomiguelino deleted the fix-query-parameter-handling branch January 28, 2025 21:36

Provide feedback