Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ optional arguments:
* Azure Audit - Azure user read-only access

## Installation
(in order to avoid missing with the already installed python libraries)
(in order to avoid messing with the already installed python libraries)

- get project `git clone https://github.com/SecurityFTW/cs-suite.git &&
cd cs-suite/`
Expand All @@ -77,7 +77,7 @@ cd cs-suite/`

- signup and have logged in already to [azure.microsoft.com](https://azure.microsoft.com)
- install azure CLI `brew install az`
- authenticate the azure cli `az login`, you should see your subscription type if it was successful, simiarly to the response below:
- authenticate the azure cli `az login`, you should see your subscription type if it was successful, similar to the response below:


```
Expand Down
4 changes: 2 additions & 2 deletions modules/awsaudit.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def prowler(check):


def multi_threaded_prowler():
""" this function using multi-threading for prowler """
""" this function uses multi-threading for prowler """
print ("Started Prowler")

checks = ['check13', 'check14', 'check15', 'check16', 'check17', 'check18', 'check19',\
Expand Down Expand Up @@ -161,7 +161,7 @@ def audit_aws_config():


def audit_aws_dns():
""" this function is to DNS """
""" this function is to perform DNS audit """
print ("Started AWS DNS Audit ")
with open('reports/AWS/aws_audit/%s/%s/delta/dns' % (account_name, timestmp), 'w') as output:
subprocess.call(['./scripts/audit_aws_dns.sh'], stdout=output)
Expand Down
6 changes: 3 additions & 3 deletions modules/azureaudit.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,20 @@ def merge_json():


def no_guest_user():
""" The response is empty,need to dig in further """
""" The response is empty, need to dig in further """
guest_user_list = subprocess.check_output(['az ad user list --query "[?additionalProperties.userType==\'Guest\']"'], shell=True)
result = {}
result['check'] = 'NO_GUEST_USER'
with open('azure_output.json', 'w') as f:
f.write(guest_user_list)

def custom_owner_role():
""" The response is huge need to break down and analyse """
""" The response is huge, need to break down and analyse """
definition_list = subprocess.check_output(['az role definition list'], shell=True)
print definition_list

def automatic_provising_agent():
print "2.2: Checking for Automatic Provising Agent\n\n"
print "2.2: Checking for Automatic Provisioning Agent\n\n"
agent_provising = subprocess.check_output(['az account get-access-token --query "{subscripton:subscription,accessToken:accessToken}" --out tsv | xargs -L1 bash -c \'curl -s -X GET -H "Authorization: Bearer $1" -H "Content-Type:application/json" https://management.azure.com/subscriptions/$0/providers/microsoft.Security/policies?api-version=2015-06-01-preview\' | jq \'.|.value[] | select(.name=="default")\'| jq \'.properties.logCollection\' | tr -d \'"\''], shell=True).strip()
result = {}
result['check'] = 'AUTOMATIC_PROVISING_AGENT'
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def main():
subprocess.call(['sudo', 'tar', '-xvf', 'sshpass-1.06.tar.gz'], cwd = './tools')
subprocess.check_output(['sudo', './configure'], cwd='tools/sshpass-1.06')
subprocess.call(['sudo', 'make', 'install'], cwd='tools/sshpass-1.06/')
print ("Please enter your AWS credetionals")
print ("Please enter your AWS credentials")
subprocess.call(['aws', 'configure'])
except:
print ("FAILED in one of the steps")
Expand Down