-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add MicroSD PSBT File support for SeedSignerOS #281
base: dev
Are you sure you want to change the base?
Conversation
Really appreciate your work on this feature, I am excited to give it a try. We might consider some kind of admonition screen? I feel as though the process of moving a PSBT with a memory card incurs some additional risk we may want to make users aware of? Open to other perspectives on this if they are out there. |
@SeedSigner definitely open to ideas. The feature is disabled by default as implemented. I'm not sure what specific risks we would want to call out in a warning screen. |
This gets a bit into the weeds, but for me its an unknown whether mounting the volume on the MicroSD, or accessing / interacting with the volume in other ways (file creation, renaming, etc.) could trigger malicious code that could also be present on the memory card. Removable media containing a file system would seem in general to have a broader attack surface than the QR exchange process. With the OS in RAM, its likely to only impact the current SeedSigner session, but we may seek out someone with more deeply relevant expertise as we consider the best way to activate and message about this issue. |
2e5993d
to
ef286c2
Compare
rebased and resolved conflicts |
Design and workflow considerations and tradeoffs
Testing/Draft status
Easiest way to test right now is to build a image and pull code from my repo/branch
This works on my M1 Mac and takes about 40 minutes to build the image.