Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Upgrade CMSSW to 14_1_0_pre0 #373

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Upgrade CMSSW to 14_1_0_pre0 #373

merged 4 commits into from
Mar 9, 2024

Conversation

ariostas
Copy link
Member

@ariostas ariostas commented Mar 1, 2024

Following @slava77's suggestion in #372, this PR upgrades CMSSW to 14_1_0_pre0. There were some minor changes that needed to be made to account for the newer version of Alpaka.

Since it now uses CUDA 12.2, I checked using the Warnings flag to see if the printf bug #354 was fixed. It wasn't fixed, but I did notice that there were some errors due to the warnings being treated as errors that I forgot to fix in #367, so I fixed them.

I marked this PR as draft since it shouldn't be merged yet for a few reasons:

  • cgpu1 currently has a driver version that is not compatible with CUDA 12
  • There needs to be a corresponding branch in the cmssw repo (I'll work on that)
  • We could use pre1 if it happens to release soon

@ariostas
Copy link
Member Author

ariostas commented Mar 5, 2024

/run cmssw CMSSW_14_1_0_pre0_LST_X

Copy link

github-actions bot commented Mar 5, 2024

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

Copy link
Contributor

@slava77 slava77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good to me.
I don't have a strong feeling of having to wait for a pre1 release instead.
There is an effort to add cuda 12.4, perhaps that will be a better opportunity than catching pre1.

@ariostas ariostas marked this pull request as ready for review March 7, 2024 23:38
@ariostas ariostas changed the title Upgrade CMSSW to 14_1_x Upgrade CMSSW to 14_1_0_pre0 Mar 8, 2024
@ariostas
Copy link
Member Author

ariostas commented Mar 8, 2024

I added a bug fix that @slava77 found out since it's somewhat related to the CUDA upgrade and it's small enough that it doesn't really need its own PR.

nvcc was only generating SASS code for sm_70 and sm_89. This meant that the A30 on cgpu-1 couldn't be used since it's sm_80. Now it also generates PTX code for compute_70, which can be JIT-compiled to sm_80.

SDL/Makefile Outdated Show resolved Hide resolved
@slava77 slava77 merged commit 1b7eccf into master Mar 9, 2024
1 check passed
@slava77
Copy link
Contributor

slava77 commented Apr 9, 2024

There is an effort to add cuda 12.4, perhaps that will be a better opportunity than catching pre1.

CUDA 12.4 is available since 14_1_0_pre2 (released Mar 28)

@ariostas
Copy link
Member Author

ariostas commented Apr 9, 2024

CUDA 12.4 is available since 14_1_0_pre2 (released Mar 28)

I think we should wait for pre_3 since the ROCm fix didn't make it to pre_2

@ariostas ariostas deleted the upgrade_to_cmssw_14_1_x branch April 23, 2024 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants