Remove cppitertools + Small Cleanup

[GNiendorf]

Small cleanup PR that removes cppitertools and unused/duplicate files. I noticed that cppitertools was only used in trkCore.cc and imported but unused in a bunch of other places and figured I would remove it and get rid of the directory.

[GNiendorf]

My last commit gets rid of the unused helper.cc/h and renames helper_v2.cc/h to just helper.cc/h

[GNiendorf]

Last commit makes pt cut configurable with --pt_cut flag for lst_plot_performance.py and -p flag for createPerfNumDenHists.

[GNiendorf]

/run standalone
/run cmssw

[github-actions]

There was a problem while building and running in standalone mode. The logs can be found here.

[GNiendorf]

@ariostas Not sure how to coordinate this, but after this PR is merged I think you'll have to update your CI a bit: Getting this error on the standalone "rm: cannot remove 'src/helper_v2.o': No such file or directory" since I renamed helper_v2 to just helper and deleted the old helper.cc that was just an outdated version of the _v2

[ariostas]

@GNiendorf Yeah, I'll change it so that it runs make clean || echo "skip" so that the CI doesn't stop if it doesn't delete something.

The CMSSW check still doesn't work since I haven't updated the step2 file, but hopefully in a couple of hours it should work.

[github-actions]

There was a problem while building and running with CMSSW. The logs can be found here.

[GNiendorf]

Last commit is an attempt at fixing issue #306, removing as much of the remaining legacy CPU code as I can and moving only what's used in the GNN output filling to SDLMath.h. @jkguiang Can you check the GNN ntuple to confirm there are no changes when you get a chance? Thank you.

[GNiendorf]

It looks like make_classfiles is a duplicate of this code here: https://github.com/cmstas/Software/blob/739fe8d21e76d52623f8ff70e68c2f17ae923176/makeCMS3ClassFiles/make_classfiles.py

Edit: I noticed trktree.cc also has this same format, probably generated from make_classfiles.py. With that in mind I think it's good to keep it in the repo, even though it is pulled from above.

[GNiendorf]

I think this PR is ready for review when you get a chance @slava77.

[slava77]

/run standalone
/run cmssw

[github-actions]

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

The full set of validation and comparison plots can be found here.

[github-actions]

There was a problem while building and running with CMSSW. The logs can be found here.

[github-actions]

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks

The full set of validation and comparison plots can be found here.

[GNiendorf]

I think the variation in the CMSSW plots is because my other PR #374 was merged in recently, so this is really showing the change due to that PR.

[GNiendorf]

/run cmssw

[github-actions]

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks

The full set of validation and comparison plots can be found here.

[sgnoohc]

i don't see any problematic things. so it LGTM.

[slava77]

there are a couple of simple updates that could be done now.
although with some good arguments could be done in a followup PR.

[GNiendorf]

Last commit fixes known issue where the y-axis would be cut off sometimes in comparison plots. Left is before, right is after my last commit.

[GNiendorf]

@slava77 This PR should be good to go if you don't have any comments about my last 2 commits.

[slava77]

/run standalone

[github-actions]

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

The full set of validation and comparison plots can be found here.