This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Fix ROCm compilation #390
Merged
Fix ROCm compilation #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is the TrackLooper-actions |
Not yet, I'll do that once this PR gets merged. |
slava77
reviewed
Apr 17, 2024
|
/run standalone |
|
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.
The full set of validation and comparison plots can be found here. |
|
The PR was built and ran successfully with CMSSW. Here are some plots. OOTB All Tracks
The full set of validation and comparison plots can be found here. |
slava77
approved these changes
Apr 18, 2024
|
The ROCm compilation is now being tested by the CI after SegmentLinking/TrackLooper-actions#12. I tested that it works well in https://github.com/SegmentLinkingTests/TrackLooper/pull/19 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slava77 found that in #381 there was an issue with the makefile causing
sdl_rocmto fail to compile. I also found thatsdl_make_tracklooperwas not checking if this file was generated, which is probably why I missed this issue when working on #381.