Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Upgrade to CMSSW 14_1_0_pre3 #396

Merged
merged 2 commits into from
May 3, 2024
Merged

Upgrade to CMSSW 14_1_0_pre3 #396

merged 2 commits into from
May 3, 2024

Conversation

ariostas
Copy link
Member

CMSSW 14_1_0_pre3 was released recently and it has some nice additions, including CUDA 12.4 (which fully fixes the printf issue from a while back), and fixes the ROCm compilation so that is can now compile LSTCore.

This PR goes along with the new CMSSW_14_1_0_pre3_LST_X branch of the CMSSW repo.

This works fine on cgpu-1, but I have to make sure that it also works on the Cornell machines since they have a slightly older nvidia driver.

@ariostas
Copy link
Member Author

ariostas commented May 2, 2024

With the current setup, the ROCm version fails to link on the Cornell machines. There's an issue with incompatible versions of libstdc++ and I haven't been able to track down why it tries to use different versions.

For lnx4555 we can simply not use Apptainer and change the setup.sh script so that it uses the el9_amd64_gcc12 platform.

For lnx7188, I have tried switching the platform to slc7_amd64_gcc12 (without Apptainer) and also tried using various different container images, but nothing works. The CUDA and CPU versions work fine, though.

So do you guys think it would be fine if I modify the setup.sh so that it uses el9 for lnx4555 and el8 for lnx7188 and cgpu-1, and we stop using Apptainer for lnx4555, and just accept that the ROCm version doesn't compile on lnx7188 (which we can't run anyway)? Maybe @GNiendorf should be the one to comment on this.

@GNiendorf
Copy link
Member

@ariostas That sounds fine to me.

@ariostas ariostas marked this pull request as ready for review May 3, 2024 14:40
@ariostas
Copy link
Member Author

ariostas commented May 3, 2024

/run standalone
/run cmssw CMSSW_14_1_0_pre3_LST_X

Copy link

github-actions bot commented May 3, 2024

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     42.9    321.8    121.5     69.6     93.3    543.6    130.2    156.8    103.6      1.9    1585.2     998.7+/- 268.8     432.4   explicit_cache[s=4] (master)
   avg     43.0    324.4    123.0     70.7     93.6    550.4    129.5    158.1    104.3      1.9    1599.1    1005.6+/- 264.9     438.4   explicit_cache[s=4] (this PR)

Copy link
Member

@GNiendorf GNiendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge after CI finishes.

Copy link

github-actions bot commented May 3, 2024

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@GNiendorf GNiendorf merged commit 113d561 into master May 3, 2024
3 checks passed
@ariostas ariostas deleted the upgrade_cmssw branch May 8, 2024 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants