Merge pull request cms-sw#46973 from iarspider/iarspider-patch-202412…

…17-3 [Geometry] Use std::abs to fix clang compilation warnings
SegmentLinking · Dec 22, 2024 · 3950ee4 · 3950ee4
2 parents b523ab3 + 66e2850
commit 3950ee4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/DetectorDescription/DDCMS/test/DDFilteredView.find.cppunit.cc b/DetectorDescription/DDCMS/test/DDFilteredView.find.cppunit.cc
@@ -70,8 +70,8 @@ void testDDFilteredViewFind::checkFilteredView() {
   double radLength = fview.getNextValue("TrackerRadLength");
   std::cout << radLength << "\n";
   double xi = fview.getNextValue("TrackerXi");
-  CPPUNIT_ASSERT(abs(radLength - refRadLength_) < 10e-6);
-  CPPUNIT_ASSERT(abs(xi - refXi_) < 10e-6);
+  CPPUNIT_ASSERT(std::abs(radLength - refRadLength_) < 10e-6);
+  CPPUNIT_ASSERT(std::abs(xi - refXi_) < 10e-6);
 
   std::cout << "TrackerRadLength = " << radLength << "\nTrackerXi = " << xi << "\n";
 

diff --git a/DetectorDescription/DDCMS/test/DDFilteredView.get.cppunit.cc b/DetectorDescription/DDCMS/test/DDFilteredView.get.cppunit.cc
@@ -69,8 +69,8 @@ void testDDFilteredViewGet::checkFilteredView() {
 
   double radLength = fview.getNextValue("TrackerRadLength");
   double xi = fview.getNextValue("TrackerXi");
-  CPPUNIT_ASSERT(abs(radLength - refRadLength_) < 10e-6);
-  CPPUNIT_ASSERT(abs(xi - refXi_) < 10e-6);
+  CPPUNIT_ASSERT(std::abs(radLength - refRadLength_) < 10e-6);
+  CPPUNIT_ASSERT(std::abs(xi - refXi_) < 10e-6);
 
   std::cout << "TrackerRadLength = " << radLength << "\nTrackerXi = " << xi << "\n";
   auto vals = fview.getValuesNS<std::string>("TrackerRadLength");

diff --git a/DetectorDescription/DDCMS/test/DDFilteredView.goto.cppunit.cc b/DetectorDescription/DDCMS/test/DDFilteredView.goto.cppunit.cc
@@ -65,8 +65,8 @@ void testDDFilteredViewGoTo::checkFilteredView() {
 
   double radLength = fview.get<double>("TrackerRadLength");
   double xi = fview.getNextValue("TrackerXi");
-  CPPUNIT_ASSERT(abs(radLength - refRadLength_) < 10e-6);
-  CPPUNIT_ASSERT(abs(xi - refXi_) < 10e-6);
+  CPPUNIT_ASSERT(std::abs(radLength - refRadLength_) < 10e-6);
+  CPPUNIT_ASSERT(std::abs(xi - refXi_) < 10e-6);
 
   std::cout << "TrackerRadLength = " << radLength << "\nTrackerXi = " << xi << "\n";