Remove device initialization from library (CMSSW side) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariostas
force-pushed
the
move_device_initialization
branch
from
354c6d3 to
fe7725d
Compare
slava77
reviewed
Apr 22, 2024
| @@ -29,7 +29,7 @@ class LSTModulesDevESProducer : public ESProducer { | |||
|
|
|||
| static void fillDescriptions(edm::ConfigurationDescriptions &descriptions); | |||
|
|
|||
| std::optional<SDL::modulesBuffer<alpaka_common::DevHost>> produce(const TrackerRecoGeometryRecord &iRecord); | |||
| std::optional<SDL::modulesBuffer<SDL::Dev>> produce(device::Record<TrackerRecoGeometryRecord> const& iRecord); | |||
There was a problem hiding this comment.
is the CopyToDevice<SDL::modulesBuffer<alpaka_common::DevHost>> needed after this change?
There was a problem hiding this comment.
That's a good point. It should no longer be needed.
slava77
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the CMSSW side of SegmentLinking/TrackLooper#385.