Fix virtual destructors

SeisSol · Dec 29, 2023 · 66bd465 · 66bd465
1 parent 5613804
commit 66bd465
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 2 deletions.
diff --git a/src/input/MeshData.h b/src/input/MeshData.h
@@ -30,6 +30,8 @@ class MeshData {
 
 class FullStorageMeshData : public MeshData {
   public:
+  virtual ~FullStorageMeshData() = default;
+
   virtual std::size_t cellCount() { return cellCountValue; }
   virtual std::size_t vertexCount() { return vertexCountValue; }
 

diff --git a/src/input/MeshInput.h b/src/input/MeshInput.h
@@ -40,7 +40,7 @@ class ApfMeshInput : public FullStorageMeshData {
   public:
   apf::Mesh2* getMesh() { return m_mesh; }
 
-  ~ApfMeshInput() {
+  virtual ~ApfMeshInput() {
     delete m_mesh;
     m_mesh = nullptr;
   }

diff --git a/src/input/NetCDFMesh.h b/src/input/NetCDFMesh.h
@@ -30,6 +30,8 @@
  */
 class NetCDFMesh : public FullStorageMeshData {
   public:
+  virtual ~NetCDFMesh() = default;
+
   NetCDFMesh(const char* meshFile, MPI_Comm comm = MPI_COMM_WORLD) {
     int rank = 0;
     int nProcs = 1;

diff --git a/src/input/SerialMeshFile.h b/src/input/SerialMeshFile.h
@@ -28,6 +28,9 @@
  * Read a mesh from a serial file
  */
 template <typename T> class SerialMeshFile : public FullStorageMeshData {
+  public:
+  virtual ~SerialMeshFile() = default;
+
   private:
 #ifdef PARALLEL
   MPI_Comm m_comm;

diff --git a/src/pumgen.cpp b/src/pumgen.cpp
@@ -342,7 +342,7 @@ int main(int argc, char* argv[]) {
   case 6:
 #ifdef USE_SIMMOD
 #ifdef USE_SCOREC
-    logInfo(rank) << "Using SimModSuite (with APF)";
+    logInfo(rank) << "Using SimModSuite with APF (deprecated)";
 
     meshInput = new SimModSuiteApf(
         inputFile, args.getArgument<const char*>("cad", 0L),