Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest, change default SIF_NAME, change ln command #49

Merged
merged 3 commits into from
May 22, 2024

Conversation

Thomas-Ulrich
Copy link
Contributor

@Thomas-Ulrich Thomas-Ulrich commented May 22, 2024

Hi,

  • I don't see the point of not using latest for the non-arm. Therefore changed.
  • removed job.jupyter and document the workflow described on the training slides, based on a VNC job.
  • fix symbolic link command ln -sf $(realpath my-training.sif) ~/my-training.sif
  • rename source_modules.sh → setup_modules_Frontera_vnc.sh (more explicit name)

@Thomas-Ulrich Thomas-Ulrich requested a review from sebwolf-de May 22, 2024 08:52
@Thomas-Ulrich Thomas-Ulrich marked this pull request as draft May 22, 2024 09:04
Base automatically changed from zihua/testing to main May 22, 2024 09:08
@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/last_modifs branch 2 times, most recently from 0478f1f to 5cec860 Compare May 22, 2024 09:30
@Thomas-Ulrich Thomas-Ulrich marked this pull request as ready for review May 22, 2024 09:33
@Aangniu
Copy link
Contributor

Aangniu commented May 22, 2024

Will this directory $SHARED_PATH/$SIF_NAME work here?

#
SHARED_PATH="/your/path/to/container/"
SIF_NAME="$HOME/my-training.sif"

if [ ! -f $SIF_NAME ]; then
    if [ ! -f $SHARED_PATH/$SIF_NAME ]; then

@Thomas-Ulrich
Copy link
Contributor Author

Will this directory $SHARED_PATH/$SIF_NAME work here?

#
SHARED_PATH="/your/path/to/container/"
SIF_NAME="$HOME/my-training.sif"

if [ ! -f $SIF_NAME ]; then
    if [ ! -f $SHARED_PATH/$SIF_NAME ]; then

@Aangniu you are right. See proposed change.

@AliceGabriel AliceGabriel self-assigned this May 22, 2024
Copy link
Collaborator

@sebwolf-de sebwolf-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the setup, but LGTM.

frontera.md Outdated
Comment on lines 15 to 16
apptainer pull -F docker://seissol/training:latest
apptainer build -f my-training.sif singularity.def
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull and build seem to be duplicate here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so we should remove the line apptainer pull -F docker://seissol/training:latest ?

@Thomas-Ulrich Thomas-Ulrich merged commit fc725fe into main May 22, 2024
1 check passed
@Thomas-Ulrich Thomas-Ulrich deleted the thomas/last_modifs branch May 22, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants