Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use seissol v1.3/Rusanov fluxes/ vtkhdf/ extend tpv13 #52

Merged
merged 24 commits into from
Nov 11, 2024

Conversation

Thomas-Ulrich
Copy link
Contributor

No description provided.

@Thomas-Ulrich
Copy link
Contributor Author

I think it is worth updating to the vtkhdf output:
image
image
vs the older output:
image
image

@Thomas-Ulrich Thomas-Ulrich changed the title use seissol v1.2 and Rusanov fluxes use seissol v1.3 and enable Rusanov fluxes Nov 7, 2024
@Thomas-Ulrich Thomas-Ulrich changed the title use seissol v1.3 and enable Rusanov fluxes use seissol v1.3/Rusanov fluxes/ vtkhdf Nov 7, 2024
@AliceGabriel
Copy link
Collaborator

Thank you Thomas!
I agree about updating the output.
Question: how different is the output after switching the flux in this coarse mesh?

@Thomas-Ulrich
Copy link
Contributor Author

the figure above shows a qualitative answer.

@AliceGabriel
Copy link
Collaborator

Do you mind plotting them in the same figure

@AliceGabriel
Copy link
Collaborator

But overall I agree- we should update this

@AliceGabriel
Copy link
Collaborator

Do you mind plotting them in the same figure

@Thomas-Ulrich
Copy link
Contributor Author

Ok, it turns out the
reader.UpdateTimeStep(5.) that we had first meant read at time simulation time 5+1
(makes not much sense but that what I got when testing).
Anyway, if I put reader.UpdateTimeStep(9.) and compare with the file 'output/{prefix}-free-surface-4.vtkhdf', I get matching data:

image

@Thomas-Ulrich
Copy link
Contributor Author

Latest changes:

  • I realized that pv.Plotter() needs to be closed to avoid memory leaks (leading to the RAM getting filled if you play to much with the iterative plots. Now that's fixed.
  • Since the last exercise is based on the xdmf output, I reverted to fault xdmf, also because this does not brings much improvement.
  • I've added one more step in the rupture speed analysis, in which we decrease initial stress to suppress supershear.

@Thomas-Ulrich
Copy link
Contributor Author

Thomas-Ulrich commented Nov 9, 2024

I added a small text detailing the initial stress and choice of mu_s in the nucleation area.

@Thomas-Ulrich Thomas-Ulrich marked this pull request as ready for review November 11, 2024 09:46
Copy link
Collaborator

@davschneller davschneller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from looking over the source.

(do we even need the Dockerfile, i.e. the Frontera container, at the moment? It's not built right now anyways)

tpv13/parameters.par Show resolved Hide resolved
@Thomas-Ulrich
Copy link
Contributor Author

(do we even need the Dockerfile, i.e. the Frontera container, at the moment? It's not built right now anyways)

you mean, frontera does not need a specific file anymore and we can remove the file?

@davschneller
Copy link
Collaborator

davschneller commented Nov 11, 2024

(do we even need the Dockerfile, i.e. the Frontera container, at the moment? It's not built right now anyways)

you mean, frontera does not need a specific file anymore and we can remove the file?

It still does need a special one. However, our CI doesn't build it at the moment (that can be fixed quite easily though)—the question would be: do we need it for the trainings still? (or at least, at the moment?)

@Thomas-Ulrich Thomas-Ulrich changed the title use seissol v1.3/Rusanov fluxes/ vtkhdf use seissol v1.3/Rusanov fluxes/ vtkhdf/ extend tpv13 Nov 11, 2024
@Thomas-Ulrich Thomas-Ulrich merged commit 1b2bad0 into main Nov 11, 2024
1 check passed
@davschneller davschneller deleted the thomas/rusanov branch November 11, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants