Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting, Re-enabling the CI, Licensing Info and one Bugfix #3

Merged
merged 20 commits into from
Sep 27, 2024

Conversation

davschneller
Copy link
Contributor

A refactoring PR with one tiny bugfix.

  • We make the clang formatting style conform to the one of SeisSol. The clang-tidy style is still different however—but can be adjusted when needed.
  • The unit tests are re-enabled. Also the tests for clang-format and clang-tidy are included.
  • We conform to the REUSE specification now—i.e. every file has licensing information.
  • Fixed a bug, where floating point numbers without an explicit sign after the d were not converted to a YAML-compatible float. As a result, now, 0d0 is now parsed correctly to 0e0 which is understood by YAML. Previously, it would have worked only for e.g. 0d+0.
  • Add newlines everywhere.

@davschneller
Copy link
Contributor Author

davschneller commented Aug 1, 2024

@ravil-mobile : is it OK for you to be credited in the copyrights like it is right now? (since you had it under your own Github account until this year)

(edit: got the "OK" on slack)

@davschneller davschneller marked this pull request as ready for review September 17, 2024 17:16
LICENSES/MIT.txt Show resolved Hide resolved
include/FtyPolicies.hpp Show resolved Hide resolved
include/FtyPolicies.hpp Show resolved Hide resolved
include/FtyPolicies.hpp Show resolved Hide resolved
include/StringProcessor.hpp Show resolved Hide resolved
tests/BlockProcessorTest.cpp Show resolved Hide resolved
tests/helper.cpp Show resolved Hide resolved
@vikaskurapati vikaskurapati merged commit c637329 into master Sep 27, 2024
4 checks passed
@davschneller davschneller deleted the davschneller/reuse-and-tests branch September 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants