Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip mongodb extension if extension is not installed #1825

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Skip mongodb extension if extension is not installed #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ab2512
Skip mongodb extension if extension is not installed
lyrixx Aug 2, 2023
99c982a
Make sure we have the mongodb/mongodb check still
Seldaek Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Monolog/Formatter/MongoDBFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ private function legacyGetMongoDbDateTime(\DateTimeInterface $value): UTCDateTim
? (int) $milliseconds
: (string) $milliseconds;

// @phpstan-ignore-next-line
return new UTCDateTime($milliseconds);
}
}
7 changes: 3 additions & 4 deletions tests/Monolog/Handler/MongoDBHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
use MongoDB\Driver\Manager;
use Monolog\Test\TestCase;

/**
* @requires extension mongodb
*/
class MongoDBHandlerTest extends TestCase
{
public function testConstructorShouldThrowExceptionForInvalidMongo()
Expand Down Expand Up @@ -56,10 +59,6 @@ public function testHandleWithLibraryClient()

public function testHandleWithDriverManager()
{
if (!(class_exists('MongoDB\Driver\Manager'))) {
$this->markTestSkipped('ext-mongodb not installed');
}

/* This can become a unit test once ManagerInterface can be mocked.
* See: https://jira.mongodb.org/browse/PHPC-378
*/
Expand Down
Loading