feat: add most popular courses statistics #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wielopolski
requested review from
typeWolffo,
piotr-pajak and
mateuszszczecina
piotr-pajak
reviewed
Nov 28, 2024
| @@ -131,6 +133,19 @@ export class StatisticsRepository { | |||
| return result; | |||
| } | |||
|
|
|||
| async getMostFivePopularCourses(userId: string) { | |||
There was a problem hiding this comment.
Suggestion: Consider renaming getMostFivsPopularCourses to getFiveMostPopularCourses.
(Logical order)
Suggested change
| async getMostFivePopularCourses(userId: string) { | |
| async getFiveMostPopularCourses(userId: string) { |
piotr-pajak
added
new feedback 🎈
wielopolski
added
review me 👀
wielopolski
added
merge me 💚
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s)
416
Overview
This PR adds response for teacher statistics and first batch of statistics related to most popular courses for teacher.