feat: courses completion for teacher statistics #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wielopolski
requested review from
typeWolffo,
piotr-pajak and
mateuszszczecina
piotr-pajak
reviewed
Nov 28, 2024
Comment on lines
+149
to
+158
| async getTotalCoursesCompletion(userId: string) { | ||
| return await this.db | ||
| .select({ | ||
| totalCoursesCompletion: sql<number>`sum(courseStatisticsPerTeacherMaterialized.completedStudentCount)`, | ||
| totalCourses: sql<number>`sum(courseStatisticsPerTeacherMaterialized.studentCount)`, | ||
| }) | ||
| .from(courseStatisticsPerTeacherMaterialized) | ||
| .where(eq(courseStatisticsPerTeacherMaterialized.teacherId, userId)); | ||
| } | ||
|
|
There was a problem hiding this comment.
suggestion: How about using Drizzle's built-in .sum() method instead of raw SQL for better type safety and readability?
Suggested change
| async getTotalCoursesCompletion(userId: string) { | |
| return await this.db | |
| .select({ | |
| totalCoursesCompletion: sql<number>`sum(courseStatisticsPerTeacherMaterialized.completedStudentCount)`, | |
| totalCourses: sql<number>`sum(courseStatisticsPerTeacherMaterialized.studentCount)`, | |
| }) | |
| .from(courseStatisticsPerTeacherMaterialized) | |
| .where(eq(courseStatisticsPerTeacherMaterialized.teacherId, userId)); | |
| } | |
| async getTotalCoursesCompletion(userId: string) { | |
| return await this.db | |
| .select({ | |
| totalCoursesCompletion: courseStatisticsPerTeacherMaterialized.completedStudentCount.sum(), | |
| totalCourses: courseStatisticsPerTeacherMaterialized.studentCount.sum(), | |
| }) | |
| .from(courseStatisticsPerTeacherMaterialized) | |
| .where(eq(courseStatisticsPerTeacherMaterialized.teacherId, userId)); | |
| } | |
There was a problem hiding this comment.
It's not Rails to use .sum() at the end of an expression and get the finished result.
Drizzle is as hollow as Swiss cheese, and below I've included its “better type safety”:
piotr-pajak
added
new feedback 🎈
piotr-pajak
approved these changes
Nov 28, 2024
wielopolski
force-pushed
the
mw_feat_417_course_completion_for_teacher_statistics
branch
from
59f821e to
034fe84
Compare
wielopolski
added
merge me 💚
wielopolski
deleted the
mw_feat_417_course_completion_for_teacher_statistics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s)
417
Overview
This PR adds courses completion to teacher statistics endpoint.