-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Five Most Popular Courses Chart #266
Conversation
0ad4457
to
cb801a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its teacher statistics, not user
or admin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this file?
<Customized | ||
component={() => { | ||
return isEmptyChart ? ( | ||
<Text | ||
x={0} | ||
textAnchor="middle" | ||
verticalAnchor="middle" | ||
className="fill-primary-950 h5 md:h3 translate-x-1/2 translate-y-1/2" | ||
> | ||
No data available | ||
</Text> | ||
) : null; | ||
}} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Customized | |
component={() => { | |
return isEmptyChart ? ( | |
<Text | |
x={0} | |
textAnchor="middle" | |
verticalAnchor="middle" | |
className="fill-primary-950 h5 md:h3 translate-x-1/2 translate-y-1/2" | |
> | |
No data available | |
</Text> | |
) : null; | |
}} | |
/> | |
<Customized | |
component={() => | |
isEmptyChart && ( | |
<Text | |
x={0} | |
textAnchor="middle" | |
verticalAnchor="middle" | |
className="fill-primary-950 h5 md:h3 translate-x-1/2 translate-y-1/2" | |
> | |
No data available | |
</Text> | |
); | |
} | |
/> |
what do you think about that?
export type AtLeastOne<T> = { | ||
[K in keyof T]-?: Pick<T, K> & Partial<Omit<T, K>>; | ||
}[keyof T]; | ||
|
||
export type ToMediaQueryObjectParam = AtLeastOne<{ | ||
minWidth?: number; | ||
maxWidth?: number; | ||
}>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, but probably we can keep it simple with discriminated union
export type ToMediaQueryObjectParam = {
minWidth: number;
maxWidth?: number;
} | {
minWidth?: number;
maxWidth: number;
};
…n and getConversionAfterFreemiumLesson
cb801a3
to
baedf2b
Compare
c03ca3d
to
f50d55f
Compare
Jira issue(s)
LC-410
Overview
FiveMostPopularCoursesChart
component.useMediaQuery
hook with comprehensive unit test coverage.useAdminStats
hook to handle data fetching.Screenshots
Mobile:

Desktop:
