feat: LC-481 scorm student view #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typeWolffo
force-pushed
the
jw_feat_lc-481_scorm_student_view
branch
from
0cb80dc to
ad7ad3a
Compare
typeWolffo
commented
Dec 16, 2024
| const parts = baseDir.split("/"); | ||
| const relParts = relativePath.split("/"); | ||
|
|
||
| let upCount = 0; |
typeWolffo
commented
Dec 16, 2024
apps/api/package.json
Outdated
| @@ -64,6 +65,7 @@ | |||
| "drizzle-orm": "0.31.2", | |||
| "drizzle-typebox": "0.1.1", | |||
| "faker": "link:@types/@faker-js/faker", | |||
| "jsdom": "^24.1.1", | |||
There was a problem hiding this comment.
Suggested change
| "jsdom": "^24.1.1", | |
| "jsdom": "24.1.1", |
typeWolffo
force-pushed
the
jw_feat_lc-481_scorm_student_view
branch
from
ad7ad3a to
f9d18ac
Compare
typeWolffo
requested review from
wielopolski,
piotr-pajak and
mateuszszczecina
typeWolffo
commented
Dec 16, 2024
| {course.isScorm ? ( | ||
| <iframe | ||
| title="Playing" | ||
| src="https://api.lms.localhost/api/scorm/dd284185-2e3b-4a06-8736-403a421a32a5/content?path=Playing/Playing.html" |
There was a problem hiding this comment.
iframe url is is temporarily hardcoded just for demo purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s)
https://selleolabs.atlassian.net/browse/LC-481
Overview
Notes