feat: 519 question match words #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wielopolski
requested changes
Dec 30, 2024
| .where(eq(questions.lessonId, lessonId)); | ||
| } | ||
|
|
||
| async upsertOptions(questionId: UUIDType) { |
There was a problem hiding this comment.
Its not a upsert method
| .where(inArray(questionAnswerOptions.questionId, questionsToDelete)); | ||
| } | ||
|
|
||
| async upsertQuestion(questionData: QuestionBody, lessonId: UUIDType, authorId: UUIDType, questionId?: UUIDType): Promise<UUIDType> { |
There was a problem hiding this comment.
Maybe can we use drizzle upsert to do it?
await db.insert(users)
.values({ id: 1, name: 'Dan' })
.onConflictDoUpdate({ target: users.id, set: { name: 'John' } });
There was a problem hiding this comment.
Great job with extracted DB methods to Repository, but I think that we need to use trx and provide it to call of method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s)
https://selleolabs.atlassian.net/browse/LC-519
Overview
Add new quiz type -> match words