Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use React.forwardRef in all components #4233

Merged
merged 49 commits into from
Feb 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
6764f3e
chore: remove .state() assertions in tests (#4232)
layershifter Jul 23, 2021
713c227
chore(Image): use React.forwardRef() (#4234)
layershifter Jul 23, 2021
e50f291
chore(Placeholder): use React.forwardRef() (#4236)
layershifter Jul 26, 2021
6cd1359
chore(Header): use React.forwardRef() (#4237)
layershifter Jul 26, 2021
50d8109
chore(Segment): use React.forwardRef() (#4238)
layershifter Jul 26, 2021
c6625c3
chore(Table): use React.forwardRef() (#4239)
layershifter Jul 26, 2021
62f307f
chore(Step): use React.forwardRef() (#4240)
layershifter Jul 26, 2021
162a2a5
chore: disable ESLint rule for function names (#4241)
layershifter Jul 26, 2021
e3ce637
chore(Comment): use React.forwardRef() (#4242)
layershifter Jul 26, 2021
269e175
chore(Card): use React.forwardRef() (#4243)
layershifter Jul 26, 2021
c4cf315
chore(Feed): use React.forwardRef() (#4244)
layershifter Jul 26, 2021
46796a0
chore(Statistic): use React.forwardRef() (#4245)
layershifter Jul 26, 2021
1886eb2
chore(Item): use React.forwardRef() (#4247)
layershifter Jul 26, 2021
8b5c445
chore(Container|Divider|Loader|Rail): use React.forwardRef() (#4248)
layershifter Jul 26, 2021
ea28b06
chore(Accordion): use React.forwardRef() (#4249)
layershifter Jul 26, 2021
bc74600
chore(Advertisement|Breadcrumb): use React.forwardRef() (#4250)
layershifter Jul 26, 2021
2f50326
chore(Message): use React.forwardRef() (#4251)
layershifter Jul 26, 2021
1984b4e
chore(Label|List): use React.forwardRef() (#4252)
layershifter Jul 26, 2021
73b8582
chore(Menu): use React.forwardRef() (#4254)
layershifter Jul 27, 2021
ed3fee7
chore(Pagination): use React.forwardRef() (#4255)
layershifter Jul 27, 2021
07702de
chore(Button): use React.forwardRef() (#4256)
layershifter Jul 27, 2021
648796a
chore(Modal|Portal|Popup): use React.forwardRef() (#4253)
layershifter Jul 27, 2021
c6fcbba
chore(Rating|Reveal): use React.forwardRef() (#4258)
layershifter Jul 28, 2021
191690d
chore(Dimmer|Grid|Sidebar): use React.forwardRef() (#4260)
layershifter Jul 28, 2021
a7aded9
chore(Modal*|Popup*): use React.forwardRef() (#4261)
layershifter Jul 29, 2021
898dc3f
chore(Confirm|Checkbox|Embed|Radio|TextArea): use React.forwardRef() …
layershifter Jul 29, 2021
ac7134a
chore(Flag|Icon|ImageGroup): use React.forwardRef() (#4264)
layershifter Jul 29, 2021
e32d6ce
chore(Tab): use React.forwardRef() (#4265)
layershifter Jul 29, 2021
41e0322
chore(TransitionGroup): use React.forwardRef() (#4266)
layershifter Jul 29, 2021
7dbf7ba
chore(Input): use React.forwardRef() (#4267)
layershifter Jul 29, 2021
e753041
chore(Sticky): use React.forwardRef() (#4263)
layershifter Jul 30, 2021
3f60f95
chore(TransitionablePortal): convert to be functional component (#4269)
layershifter Aug 2, 2021
91b35f1
chore(Search*): use React.forwardRef() (#4270)
layershifter Aug 3, 2021
2e474a9
chore(Dropdown*): use React.forwardRef() (#4273)
layershifter Aug 4, 2021
9437695
chore(Visibility): remove component (#4257)
layershifter Sep 24, 2021
5f8b882
chore(Ref): remove component (#4286)
layershifter Sep 24, 2021
6396cf2
chore(Search): use React.forwardRef() (#4330)
layershifter Feb 8, 2022
23c904f
chore: refactor Modal tests (#4339)
layershifter Feb 18, 2022
fb8c9e5
chore: remove unused test utils (#4340)
layershifter Feb 18, 2022
ca83470
chore: refactor tests for classnames to use mount() (#4341)
layershifter Feb 18, 2022
5c1d808
chore: refactor tests for shorthands to use mount() (#4342)
layershifter Feb 18, 2022
e331591
fix(Dropdown): use ref forwarding (#4338)
layershifter Feb 18, 2022
10a1633
Add forward ref to Form (#4364)
bolivier May 5, 2022
3d7166b
Add ref to components (#4373)
bolivier Jun 21, 2022
cd2b8f4
chore(FormField): use React.forwardRef() (#4359)
bolivier Apr 22, 2022
9738a3e
chore(FormTextArea): use React.forwardRef() (#4405)
felixmosh Dec 12, 2022
1b97e49
chore(FormRadio): use React.forwardRef() (#4406)
felixmosh Dec 12, 2022
d8c1c98
chore(FormInput): use React.forwardRef() (#4407)
felixmosh Dec 12, 2022
6c03c11
chore(Select,FormSelect,FormDropdown): use React.forwardRef() (#4408)
felixmosh Dec 13, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"consistent-return": "off",
"complexity": ["warn", 10],
"global-require": "off",
"func-names": "off",
"lines-between-class-members": "off",
"no-console": "error",
"no-multi-spaces": ["error", { "ignoreEOLComments": true }],
Expand Down
21 changes: 10 additions & 11 deletions docs/src/components/Sidebar/Sidebar.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import _ from 'lodash/fp'
import PropTypes from 'prop-types'
import React, { Component } from 'react'
import { Link } from 'react-static'
import { Menu, Icon, Input, Ref } from 'semantic-ui-react'
import { Menu, Icon, Input } from 'semantic-ui-react'

import CarbonAd from 'docs/src/components/CarbonAd/CarbonAd'
import Logo from 'docs/src/components/Logo/Logo'
Expand Down Expand Up @@ -229,16 +229,15 @@ class Sidebar extends Component {
</Menu.Menu>
</Menu.Item>
<Menu.Item fitted>
<Ref innerRef={this.handleSearchRef}>
<Input
fluid
icon={{ name: 'filter', color: 'teal', inverted: true, bordered: true }}
placeholder='Press "/" to filter components'
value={query}
onChange={this.handleSearchChange}
onKeyDown={this.handleSearchKeyDown}
/>
</Ref>
<Input
fluid
icon={{ name: 'filter', color: 'teal', inverted: true, bordered: true }}
placeholder='Press "/" to filter components'
ref={this.handleSearchRef}
value={query}
onChange={this.handleSearchChange}
onKeyDown={this.handleSearchKeyDown}
/>
</Menu.Item>
{query ? this.renderSearchItems() : this.menuItemsByType}
</Menu>
Expand Down
67 changes: 0 additions & 67 deletions docs/src/examples/addons/Ref/Types/RefExampleRef.js

This file was deleted.

54 changes: 0 additions & 54 deletions docs/src/examples/addons/Ref/Types/RefForwardingExample.js

This file was deleted.

30 changes: 0 additions & 30 deletions docs/src/examples/addons/Ref/Types/index.js

This file was deleted.

38 changes: 0 additions & 38 deletions docs/src/examples/addons/Ref/index.js

This file was deleted.

This file was deleted.

Loading